Some support for unicode-range and @font-face{font-weight}. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! My apologies for the silence, you caught me in a very busy time in my life unfortunately :/ On a side note, do you mind me asking in which context are you using this project (is it the library or the stand alone executable?). Just curious as to how people are using this. |
|
There's no particular hurry from my end. The above code changes sufficed, and anyway I gave up trying for pure Haskell solutions for that project, and went with Node libraries, largely because I needed Node in the stack anyway for Stylus. I was using the Hasmin library, called from a Shake build file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8.
I don't know or really understand this codebase, but I gave it a shot.
unicode-rangenow at least doesn't get mangled, although the parser is primitive and doesn't try to minify.font-weightmostly works, butfont-weight: normal boldgets changed tofont-weight:700, which is wrong, and I haven't yet figured out whynormalgets eaten. One question is whether it's better to leave this bug or defer support.